Skip to content

[Feat] - Add dynamic chain config to template #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thedarkjester wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[Feat] - Add dynamic chain config to template #1663

thedarkjester wants to merge 10 commits into from

Conversation

@thedarkjester
Copy link
Contributor

@thedarkjester thedarkjester commented Dec 16, 2025 •
edited by cursor bot
Loading

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Test A
  • Test B

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Note

Introduces configurable hooks for the Solidity verifier generators and updates templates accordingly.

  • Update groth16/bn254/solidity.go and plonk/bn254/solidity.go templates to support optional SortedImports, InterfaceDeclaration, extra Constants, Constructor, and Functions blocks
  • Add backend/solidity/solidity.go with ExportOptions: WithImport, WithInterface, WithConstants, WithConstructor, WithFunctions, plus helpers SortedImports() and InterfaceDeclaration()
  • New tests in backend/solidity/options_test.go and expanded solidity_test.go; add snapshot contracts in backend/solidity/testdata/* demonstrating all options

Written by Cursor Bugbot for commit 38416cb. This will update automatically on new commits. Configure here.

cursor[bot]
cursor bot reviewed Dec 16, 2025
View reviewed changes
@ivokub ivokub added dep: linea Issues affecting Linea downstream priority: P2-medium Issue priority: medium feat: solidity labels Dec 17, 2025
@ivokub ivokub self-assigned this Dec 17, 2025
@ivokub
Copy link
Collaborator

ivokub commented Dec 17, 2025

The plan to integrate the configuration is as follows:

  • add Solidity export options:
    • Withlmport -- multiple options. Every line goes to separate row
    • WithInheretance -- can allow multiple. In this case have to format accordingly
    • WithConstants -- additional constants to whatever is defined in the template
    • WithFunctions -- aditionnal functions which can be included in the template
      And then we replace during contract generation. On Linea side we then provide the corresponding parameters for different cases (test case generation).

Timeline-wise -- can do after new year's.

@ivokub
Copy link
Collaborator

ivokub commented Jan 10, 2026

I made the changes. I'll double check soon.

cursor[bot]
cursor bot reviewed Jan 10, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 13, 2026
View reviewed changes
ivokub
ivokub approved these changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made parametric. Otherwise looks good to me.

@ivokub ivokub requested a review from ThomasPiellard January 13, 2026 11:26
@ivokub
Copy link
Collaborator

ivokub commented Jan 13, 2026

Also added @ThomasPiellard to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@ivokub ivokub ivokub approved these changes

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees

@ivokub ivokub

Labels

dep: linea Issues affecting Linea downstream feat: solidity priority: P2-medium Issue priority: medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thedarkjester @ivokub